Skip to content

feat(home): editorial homepage, sticky top nav, and category drill-down #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhislop-design wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(home): editorial homepage, sticky top nav, and category drill-down #931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/components/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,13 @@ const MobileCard = ({
</Card>
)

export function Navbar({ children }: { children: React.ReactNode }) {
export function Navbar({
children,
hideHeader = false,
}: {
children: React.ReactNode
hideHeader?: boolean
}) {
const matches = useMatches()

const { Title } = React.useMemo(() => {
Expand All @@ -145,6 +151,10 @@ export function Navbar({ children }: { children: React.ReactNode }) {
const containerRef = React.useRef<HTMLDivElement>(null)

React.useEffect(() => {
// When hideHeader is true, the EditorialTopNav owns --navbar-height —
// skip our own measurement so we don't fight it.
if (hideHeader) return

const updateContainerHeight = () => {
if (containerRef.current) {
const height = containerRef.current.offsetHeight
Expand All @@ -161,7 +171,7 @@ export function Navbar({ children }: { children: React.ReactNode }) {
return () => {
window.removeEventListener('resize', updateContainerHeight)
}
}, [])
}, [hideHeader])

const [showMenu, setShowMenu] = React.useState(false)
const [canLoadAuthControls, setCanLoadAuthControls] = React.useState(false)
Expand Down Expand Up @@ -760,12 +770,14 @@ export function Navbar({ children }: { children: React.ReactNode }) {

return (
<>
{navbar}
{hideHeader ? null : navbar}
<div
className={twMerge(
`min-h-[calc(100dvh-var(--navbar-height))] flex flex-col
min-w-0 md:flex-row w-full transition-all duration-300
pt-[var(--navbar-height)]`,
min-w-0 md:flex-row w-full transition-all duration-300`,
// The fixed navbar (when shown) pushes children down; the editorial
// top nav is sticky/in-flow above, so we don't need extra padding.
hideHeader ? '' : 'pt-[var(--navbar-height)]',
)}
>
{smallMenu}
Expand Down
Loading
Loading