refactor: Remove exceptions from Network Spawn Manager#3932
Merged
noellie-velez merged 7 commits intorefactor/remove-exceptions-network-spawn-managerfrom Apr 7, 2026
Merged
refactor: Remove exceptions from Network Spawn Manager#3932noellie-velez merged 7 commits intorefactor/remove-exceptions-network-spawn-managerfrom
noellie-velez merged 7 commits intorefactor/remove-exceptions-network-spawn-managerfrom
Conversation
* Converted `private m_LocalNetworkManage` r to `internal LocalNetworkManager` to use a cached Network Manager field instead of a property (optimization pass) * Update changelog
* Use NetworkManager field instead of property when available * Update changelog
* CI update * Disabled ConnectSingleClient_Hostname for Android
) * fix Fixing exception that could be thrown in NetworkLog if there is no NetworkManager instance. Adding additional check in NetworkObject.OnNetworkBehaviourDestroyed to assure nothing is ever logged about destroying a NetworkBehaviour when shutting down and the NetworkObject is still considered spawned. * test The test that validates the NetworkLog fix. * update Adding change log entry for this fix.
* Updates on internal CreateAndSpawnPlayer: - Move out the `if DA` check from the function - Early return - Add a LogWarning if no playerPrefab was fetched --------- Co-authored-by: Emma <emma.mcmillan@unity3d.com>
* Use cached NetworkManager instead of a field to avoid lazy instantiation overhead and associated performance cost * Remove un-needed extra local networkManager var layer to use global cached one * Update changelog --------- Co-authored-by: Unity Netcode CI <74025435+netcode-ci-service@users.noreply.github.com>
* Use cached `NetworkManager` instead of a field to avoid lazy instantiation overhead and improve performance * Convert `RegisterForTickUpdate` to non-static since static context was unnecessary and prevented use of cached `NetworkManager` * Cache `tickRate` to reduce repeated lookups * Remove redundant local `NetworkManager` variable in `RegisterForTickUpdate` for consistency * Add `networkObject.name` to `NetcodeTransformMessage` * Update changelog --------- Co-authored-by: Emma <emma.mcmillan@unity3d.com> Co-authored-by: Noel Stephens <noel.stephens@unity3d.com>
noellie-velez
merged commit 0103c74
into
refactor/remove-exceptions-network-spawn-manager
215 of 241 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Remove exceptions from Network Spawn Manager
Jira ticket
MTT-14791
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports