Adjust validation of memory in canonopts#633
Open
alexcrichton wants to merge 1 commit intoWebAssembly:mainfrom
Open
Adjust validation of memory in canonopts#633alexcrichton wants to merge 1 commit intoWebAssembly:mainfrom
memory in canonopts#633alexcrichton wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
Change the subtyping check to check for `(memory 0)` instead of `(memory 1)` to allow memories that start empty but are allowed to grow. This is a bit more relaxed from the previous predicate while still restricting it to non-shared, 32-bit, 64k page-size memories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the subtyping check to check for
(memory 0)instead of(memory 1)to allow memories that start empty but are allowed to grow. This is a bit more relaxed from the previous predicate while still restricting it to non-shared, 32-bit, 64k page-size memories.