Skip to content

Fix: Revision REST schema remove protected#11569

Open
DarkMatter-999 wants to merge 4 commits intoWordPress:trunkfrom
DarkMatter-999:53417-fix-revision-rest-schema-protected
Open

Fix: Revision REST schema remove protected#11569
DarkMatter-999 wants to merge 4 commits intoWordPress:trunkfrom
DarkMatter-999:53417-fix-revision-rest-schema-protected

Conversation

@DarkMatter-999
Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/53417

The schema provided by the REST API endpoints for revisions at wp/v2/posts/{id}/revisions and wp/v2/pages/{id}/revisions incorrectly states that content.protected and excerpt.protected properties exist. Revisions do not inherently support password protection in their response payloads, as they belong to the parent post.

This PR fixes the issue by removing the protected property from the revision schema for both the content and excerpt fields within WP_REST_Revisions_Controller::get_item_schema().

Use of AI Tools

AI assistance: Yes
Tool(s): Github Copilot (Claude 4.6 Sonnet, Gemini 3.1 Pro)
Used for: Discussing the implementation approach and refining the PHPUnit tests for schema validation. Final code and tests were reviewed and verified locally by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@DarkMatter-999 DarkMatter-999 marked this pull request as ready for review April 14, 2026 11:00
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props lakshyajeet.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant