Filesystem: Update constructor parameter default value to an empty array#11593
Filesystem: Update constructor parameter default value to an empty array#11593Soean wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| * @param array $opt | ||
| */ | ||
| public function __construct( $opt = '' ) { | ||
| public function __construct( $opt = array() ) { |
There was a problem hiding this comment.
Make sure to add docblock for the param
2 participants
This pull request updates the constructors of two filesystem classes to use an empty array as the default value for the
$optparameter, instead of an empty string. This change improves type consistency and prevents potential issues when the parameter is expected to be an array.Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.