Skip to content

Code Quality: Declare WP globals and initialize variables for PHPStan level 1 #11979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huzaifaalmesbah wants to merge 1 commit into
base: trunk
Choose a base branch
from
+31 −2
Open

Code Quality: Declare WP globals and initialize variables for PHPStan level 1 #11979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/wp-admin/plugins.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@
/** WordPress Administration Bootstrap */
require_once __DIR__ . '/admin.php';

/**
* @global string $status Current plugin status view, set by WP_Plugins_List_Table.
* @global int $page Current page number, set by WP_Plugins_List_Table.
* @global array $plugins Set by WP_Plugins_List_Table::prepare_items().
* @global int $user_ID ID of the current user, set during authentication.
*/
global $status, $page, $plugins, $user_ID;

if ( ! current_user_can( 'activate_plugins' ) ) {
wp_die( __( 'Sorry, you are not allowed to manage plugins for this site.' ) );
}
Expand Down
9 changes: 8 additions & 1 deletion src/wp-admin/user-edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@
/** WordPress Translation Installation API */
require_once ABSPATH . 'wp-admin/includes/translation-install.php';

/**
* @global wpdb $wpdb WordPress database abstraction object.
* @global array $_wp_admin_css_colors Registered admin color schemes.
* @global WP_Roles $wp_roles The roles object.
*/
global $wpdb, $_wp_admin_css_colors, $wp_roles;

$action = ! empty( $_REQUEST['action'] ) ? sanitize_text_field( $_REQUEST['action'] ) : '';
$user_id = ! empty( $_REQUEST['user_id'] ) ? absint( $_REQUEST['user_id'] ) : 0;
$wp_http_referer = ! empty( $_REQUEST['wp_http_referer'] ) ? sanitize_url( $_REQUEST['wp_http_referer'] ) : '';
Expand Down Expand Up @@ -163,7 +170,7 @@
$user = get_userdata( $user_id );

if ( $user->user_login && isset( $_POST['email'] ) && is_email( $_POST['email'] ) && $wpdb->get_var( $wpdb->prepare( "SELECT user_login FROM {$wpdb->signups} WHERE user_login = %s", $user->user_login ) ) ) {
$wpdb->query( $wpdb->prepare( "UPDATE {$wpdb->signups} SET user_email = %s WHERE user_login = %s", $_POST['email'], $user_login ) );
$wpdb->query( $wpdb->prepare( "UPDATE {$wpdb->signups} SET user_email = %s WHERE user_login = %s", $_POST['email'], $user->user_login ) );
}
}

Expand Down
12 changes: 11 additions & 1 deletion src/wp-admin/users.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@
/** WordPress Administration Bootstrap */
require_once __DIR__ . '/admin.php';

/**
* @global WP_User $current_user The current user, set during authentication.
* @global WP_Roles $wp_roles The roles object.
* @global wpdb $wpdb WordPress database abstraction object.
* @global string $usersearch User search query, set by WP_Users_List_Table.
* @global int $blog_id The current site (blog) ID on multisite.
*/
global $current_user, $wp_roles, $wpdb, $usersearch, $blog_id;

if ( ! current_user_can( 'list_users' ) ) {
wp_die(
'<h1>' . __( 'You need a higher level of permission.' ) . '</h1>' .
Expand Down Expand Up @@ -93,7 +102,8 @@
);

if ( empty( $_REQUEST ) ) {
$referer = '<input type="hidden" name="wp_http_referer" value="' . esc_attr( wp_unslash( $_SERVER['REQUEST_URI'] ) ) . '" />';
$redirect = '';
$referer = '<input type="hidden" name="wp_http_referer" value="' . esc_attr( wp_unslash( $_SERVER['REQUEST_URI'] ) ) . '" />';
} elseif ( isset( $_REQUEST['wp_http_referer'] ) ) {
$redirect = remove_query_arg( array( 'wp_http_referer', 'updated', 'delete_count' ), wp_unslash( $_REQUEST['wp_http_referer'] ) );
$referer = '<input type="hidden" name="wp_http_referer" value="' . esc_attr( $redirect ) . '" />';
Expand Down
4 changes: 4 additions & 0 deletions src/wp-includes/user.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2265,6 +2265,9 @@ function wp_insert_user( $userdata ) {
$userdata = (array) $userdata;
}

$user_id = 0;
$old_user_data = null;

// Are we updating or creating?
if ( ! empty( $userdata['ID'] ) ) {
$user_id = (int) $userdata['ID'];
Expand Down Expand Up @@ -4272,6 +4275,7 @@ function _wp_privacy_send_request_confirmation_notification( $request_id ) {
return;
}

$manage_url = '';
if ( 'export_personal_data' === $request->action_name ) {
$manage_url = admin_url( 'export-personal-data.php' );
} elseif ( 'remove_personal_data' === $request->action_name ) {
Expand Down
Loading