Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the A2A_SAMPLES_REVISION and implements push notification support in the ITK agent, including new configuration stores and sender logic. Key changes involve updating handle_call_agent to process push notification behaviors and adding corresponding test cases in run_itk.sh. Feedback identifies a regression where the uvicorn log level was hardcoded to 'info', suggests ensuring explicit error handling for unsupported transports by removing a default fallback value, and notes several unnecessary blank lines that should be removed for better code style.
kdziedzic70
force-pushed
the
dziedzick/test-push-notifications-in-itk
branch
6 times, most recently
from
f98d72e to
e11148f
Compare
kdziedzic70
force-pushed
the
dziedzick/test-push-notifications-in-itk
branch
from
e11148f to
e038cd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR extends itk cases with push_notifications compatibility tests
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.bash scripts/format.shfrom the repository root to format)Fixes #<issue_number_goes_here> 🦕