feat: default expand action for tableview and treeview#9875
Open
snowystinger wants to merge 4 commits intomainfrom
Open
feat: default expand action for tableview and treeview#9875snowystinger wants to merge 4 commits intomainfrom
snowystinger wants to merge 4 commits intomainfrom
Conversation
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RSP Component Milestones (view)
we were originally passing an onAction that did nothing to the Tree story, which is why the row was getting the hover style
I've set it up so that if no onAction is provided, there's a default action on the row which toggles the expanded key. Because it's hooked up through onAction, it also means the disabled behavior is automatically handled, it can't conflict, and it gets the hover state automatically as well
✅ Pull Request Checklist:
📝 Test Instructions:
Go to the Tree/Table stories in S2, try combinations of controls
onAction: on/off
disabledBehavior: all/selection
selectionMode: multiple/single/none
Make sure that hover works on the row and you can toggle expansion from anywhere on the row, not just the chevron
Note, having an onAction prevents this, and disabledBehavior all
🧢 Your Project: