Add session/setTitle method#1199
Conversation
a8a6ab5 to
b9739d6
Compare
|
@benbrandt @anna239, I believe it makes sense to decide on that PR on the next meeting |
b9739d6 to
aa232d5
Compare
|
Rebased onto current @codex review |
aa232d5 to
df5ce77
Compare
|
Updated the branch to include @codex review |
Wires the SetSessionTitleRequest / SetSessionTitleResponse types into the agent-side JSON-RPC dispatch tables. Companion to agentclientprotocol/agent-client-protocol#1199, which adds the schema definitions for session/setTitle. This PR is the Rust SDK half of the round trip: once the schema crate ships a release with the new types, ACP-backed agents can implement Agent::set_session_title and have it dispatched here.
Wires the SetSessionTitleRequest / SetSessionTitleResponse types into the agent-side JSON-RPC dispatch tables. Companion to agentclientprotocol/agent-client-protocol#1199, which adds the schema definitions for session/setTitle. This PR is the Rust SDK half of the round trip: once the schema crate ships a release with the new types, ACP-backed agents can implement Agent::set_session_title and have it dispatched here.
Wires the SetSessionTitleRequest / SetSessionTitleResponse types into the agent-side JSON-RPC dispatch tables. Companion to agentclientprotocol/agent-client-protocol#1199, which adds the schema definitions for session/setTitle. This PR is the Rust SDK half of the round trip: once the schema crate ships a release with the new types, ACP-backed agents can implement Agent::set_session_title and have it dispatched here.
|
@codex review |
df5ce77 to
23977c0
Compare
Wires the SetSessionTitleRequest / SetSessionTitleResponse types into the agent-side JSON-RPC dispatch tables. Companion to agentclientprotocol/agent-client-protocol#1199, which adds the schema definitions for session/setTitle. This PR is the Rust SDK half of the round trip: once the schema crate ships a release with the new types, ACP-backed agents can implement Agent::set_session_title and have it dispatched here.
23977c0 to
f733ac6
Compare
|
Rebased onto current Validation:
@codex review |
f733ac6 to
88113ca
Compare
|
Rebased onto current Validation:
@codex review |
Summary
Adds
session/setTitleto the Agent Client Protocol, giving clients a standard way to ask an agent to rename an existing session.Title is plain UTF-8. Empty string remains valid at the protocol level so agents can decide whether that means "clear", "reset", or "use an empty title".
Why
Zed's first-party agent can already rename sessions, but ACP-backed sessions cannot, because there is no protocol method for the client to push a new title to the agent. The user-visible symptom is that the title editor in the agent panel appears for ACP threads but the rename cannot be persisted.
SessionInfoUpdatealready exists in the reverse direction (agent -> client) and carriestitle-- this PR adds the missing client -> agent half of the round-trip.How
SetSessionTitleRequestandSetSessionTitleResponseto the generated v1 and v2 agent schemas.SESSION_SET_TITLE_METHOD_NAME = "session/setTitle"to the generated metadata.session/set_modevariants non-convertible to v2.SetSessionTitle.Tests
npm run checkcovers clippy with all features, Prettier/cargo formatting checks, spellcheck, all-feature unit tests, generated-bin tests, and doctests.Companion PRs
Companion codex-acp PRs:
session/setTitleand emitSessionInfoUpdate./rename <new title>as an ACP-client-friendly shortcut.