Add model_config rfd#930
Merged
Merged
Conversation
benbrandt
approved these changes
May 7, 2026
Member
benbrandt
left a comment
benbrandt
left a comment
There was a problem hiding this comment.
I think this one is easy enough to add as a new category.
If we want to make this more semantically meaningful we could do some sort of nested config, but it gets tricky fast.
I think this is easy enough to add as a new category. I do wonder about thought_level though... since it is quite a ubiquitous config, it makes it easier to attach keyboard shortcuts too by having it distinct, but we can also group it. Not feeling strongly about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.