remove direct dependency on tokio #145
Merged
benbrandt merged 5 commits intoagentclientprotocol:mainfrom Apr 29, 2026
Merged
Conversation
Replace direct tokio usage with smol-ecosystem crates: - Stdio: use blocking::Unblock instead of tokio::io::stdin/stdout - AcpAgent: use async-process instead of tokio::process - session.rs: use futures::channel::oneshot instead of tokio::sync::oneshot - Use futures::future::select instead of tokio::select! tokio/tokio-util remain as deps only for mcp_server/builder.rs where rmcp requires tokio AsyncRead/AsyncWrite types (rmcp pulls in tokio transitively regardless). Remove agent-client-protocol-tokio from workspace and update all consumers to import from agent-client-protocol directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
agent-client-protocol-tokiodirectory. It merges that functionality into the mainagent-client-protocolcrate, usingsmolinstead oftokiofor the runtime needs (e.g., communicating with stdin, talking to a process).I believe the
smolcrate is more composable.There is still a dependency on
tokiovia rmcp. Removing that is possible but more effect so I opted not to do it for now.cc @benbrandt, what do you think