Skip to content

Fix outdated SceneStrategy.calculateScene signature in snippets#951

Open
bsagmoe wants to merge 1 commit into
mainfrom
bsagmoe/nav3-scenes
Open

Fix outdated SceneStrategy.calculateScene signature in snippets#951
bsagmoe wants to merge 1 commit into
mainfrom
bsagmoe/nav3-scenes

Conversation

@bsagmoe

@bsagmoe bsagmoe commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SceneExample interface to SceneStrategyExample as a functional interface. It changes the calculateScene method signature to be an extension function on SceneStrategyScope<T> and removes the @Composable annotation and the onBack callback parameter. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@bsagmoe bsagmoe marked this pull request as ready for review June 15, 2026 18:14
@bsagmoe bsagmoe requested a review from a team as a code owner June 15, 2026 18:14
@bsagmoe bsagmoe requested a review from raystatic June 15, 2026 18:14
@bsagmoe bsagmoe enabled auto-merge (squash) June 15, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant