-
Notifications
You must be signed in to change notification settings - Fork 11.9k
fix(@angular/build): apply file replacements to web worker entry bundles #32930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
maruthang
wants to merge
4
commits into
angular:main
from
maruthang:fix-29546-worker-file-replacements
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
703b03f
fix(@angular/cli): supplement workspace member dependencies in ng update
maruthang a2b3d52
fix(@angular/build): apply file replacements to web worker entry bundles
maruthang 4aa1c10
fix(@angular/build): apply file replacements to full worker bundle gr…
maruthang 1bbed72
perf(@angular/build): use callback in string replacement to avoid $ i…
maruthang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The manual rewriting of import specifiers in the worker entry file has several limitations and potential issues:
esbuild.buildSyncdoes not support plugins. This is a significant limitation if shared services or constants (which might import the environment) are used in the worker.import/exportkeywords inside comments or strings. Since these must be top-level statements in ESM, it's safer to anchor the regex to the start of the line.String.prototype.replacewith a string as the second argument (line 843) can lead to incorrect output if the replacement path contains special characters like$(e.g., in some Windows paths).import './utils'resolving to./utils/index.ts).While the transitive imports issue is an architectural limitation of the synchronous worker bundling, the other issues can be mitigated by using a more robust replacement approach.