Skip to content

refactor(@angular/cli): remove find_examples tool and associated database rule#33083

Merged
clydin merged 1 commit intoangular:mainfrom
clydin:cleanup/remove-find-examples
Apr 29, 2026
Merged

refactor(@angular/cli): remove find_examples tool and associated database rule#33083
clydin merged 1 commit intoangular:mainfrom
clydin:cleanup/remove-find-examples

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Apr 28, 2026

Remove the find_examples tool from the Angular CLI MCP server, along with the ng_examples_db Bazel rule and associated example files. With the availability of the official Angular developer skills repository (https://github.com/angular/skills), this local database lookup tool is redundant. Reduce maintenance overhead and simplify the codebase by eliminating the need to maintain a local SQLite database of examples within the CLI repository.

@clydin clydin added the target: major This PR is targeted for the next major release label Apr 28, 2026
…base rule

Remove the `find_examples` tool from the Angular CLI MCP server, along with the `ng_examples_db`
Bazel rule and associated example files. With the availability of the official Angular developer
skills repository (https://github.com/angular/skills), this local database lookup tool is redundant.
Reduce maintenance overhead and simplify the codebase by eliminating the need to maintain a local
SQLite database of examples within the CLI repository.
@clydin clydin force-pushed the cleanup/remove-find-examples branch from 4a67342 to b826fcf Compare April 28, 2026 21:02
@clydin clydin marked this pull request as ready for review April 28, 2026 21:17
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 28, 2026
@clydin clydin requested a review from alan-agius4 April 28, 2026 21:18
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the find_examples tool and its associated infrastructure from the Angular CLI's Model Context Protocol (MCP) server. This involves deleting the tool's implementation, database discovery logic, SQLite query utilities, example markdown files, and corresponding unit and integration tests. The Bazel build configuration has also been updated to remove the ng_examples_db rule and its usage. I have no feedback to provide.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 29, 2026
@clydin clydin merged commit e6d80aa into angular:main Apr 29, 2026
37 checks passed
@clydin
Copy link
Copy Markdown
Member Author

clydin commented Apr 29, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/cli target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants