fix(@angular/cli): fallback to deprecated versions when resolving ranges if no non-deprecated version is found (20.3.x)#33355
Merged
Conversation
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the package version selection logic for the 'range' case in the Angular CLI update command, allowing it to fall back to deprecated versions if no non-deprecated versions satisfy the requested semver range. The review feedback suggests optimizing this implementation to avoid multiple array allocations and iterations by tracking both the latest non-deprecated and deprecated versions in a single pass.
alan-agius4
force-pushed
the
update-20.3.x
branch
4 times, most recently
from
0d646f8 to
a058ba2
Compare
…ges if no non-deprecated version is found When using ng update to resolve package version ranges on the command line in 20.3.x, we previously skipped deprecated package versions entirely during pre-validation. In cases where all versions satisfying the range are deprecated, this resulted in update failure. Now, we attempt to find a satisfying version from non-deprecated versions first, and fallback to deprecated versions if none are found. This aligns the CLI pre-validation with the update schematic resolution logic. Additionally, in the update schematic, we align package group versions to the resolved version of the group leader instead of using the unresolved range, and we remove the check that prevented aligning already-present packages. This ensures that when a package in the group (like @angular/animations) is deprecated, it is correctly aligned with the other group members, preventing peer dependency conflicts during update.
alan-agius4
force-pushed
the
update-20.3.x
branch
from
a058ba2 to
b455a67
Compare
clydin
approved these changes
Jun 11, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
ng updateto resolve package version ranges on the command line in 20.3.x, we previously skipped deprecated package versions entirely during pre-validation. In cases where all versions satisfying the range are deprecated, this resulted in update failure. Now, we attempt to find a satisfying version from non-deprecated versions first, and fallback to deprecated versions if none are found. This aligns the CLI pre-validation with the update schematic resolution logic.