Skip to content

fix(ng-dev/caretaker): redact raw error objects from caretaker logs #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josephperrott wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −6
Open

fix(ng-dev/caretaker): redact raw error objects from caretaker logs #3759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ng-dev/caretaker/handoff/update-github-team.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,14 @@ async function getGroupMembers(group: string) {
})
.then(({data}) => data.map((member) => member.login));
} catch (e) {
Log.debug(e);
if (e instanceof Error) {
Log.debug(e.message);
if (e.stack) {
Log.debug(e.stack);
}
} else {
Log.debug(String(e));
}
Comment thread
josephperrott marked this conversation as resolved.
return [];
}
}
Expand Down
9 changes: 8 additions & 1 deletion ng-dev/caretaker/handoff/verify-merge-mode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,14 @@ export async function verifyMergeMode(expectedMode: MergeMode): Promise<boolean>
return true;
} catch (err) {
Log.info(`${red('✘')} Failed to update merge-mode`);
Log.info(err);
if (err instanceof Error) {
Log.info(err.message);
if (err.stack) {
Log.debug(err.stack);
}
} else {
Log.info(String(err));
}
return false;
}
}
Expand Down
6 changes: 4 additions & 2 deletions ng-dev/caretaker/merge-mode/release.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@ export async function setMergeModeRelease(): Promise<boolean> {
Log.error(' ✘ Failed to setup of repository for release');
if (err instanceof Error) {
Log.info(err.message);
Log.debug(err.stack);
if (err.stack) {
Log.debug(err.stack);
}
return false;
}
Log.info(err);
Log.info(String(err));
}
return false;
}
Expand Down
6 changes: 4 additions & 2 deletions ng-dev/caretaker/merge-mode/reset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,12 @@ export async function resetMergeMode(): Promise<boolean> {
Log.info(`${red('✘')} Failed to reset the merge mode of the repository`);
if (err instanceof Error) {
Log.info(err.message);
Log.debug(err.stack);
if (err.stack) {
Log.debug(err.stack);
}
return false;
}
Log.info(err);
Log.info(String(err));
return false;
}
}
Loading