Skip to content

fix(bazel/http-server): prevent directory traversal bypass in Http Server #3763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephperrott merged 3 commits into from
Jun 8, 2026
Merged

fix(bazel/http-server): prevent directory traversal bypass in Http Server #3763

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
057a2b6
fix(bazel/http-server): prevent directory traversal bypass in Http Se…
josephperrott Jun 6, 2026
9a5d4d7
fix(bazel/http-server): prevent double separator in root path comparison
josephperrott Jun 6, 2026
c4d3a93
fix(bazel/http-server): format code with prettier
josephperrott Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions bazel/http-server/server.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,14 @@ export class HttpServer {

// Detect if the url escapes the server's root path
for (const rootPath of this._rootPaths) {
const absoluteRootPath = path.resolve(rootPath);
const absoluteJoinedPath = path.resolve(path.posix.join(rootPath, getManifestPath(req.url)));
const resolvedRoot = path.resolve(rootPath);
const absoluteRootPath = resolvedRoot.endsWith(path.sep)
? resolvedRoot
: resolvedRoot + path.sep;
const resolvedJoined = path.resolve(path.posix.join(rootPath, getManifestPath(req.url)));
const absoluteJoinedPath = resolvedJoined.endsWith(path.sep)
? resolvedJoined
: resolvedJoined + path.sep;
if (!absoluteJoinedPath.startsWith(absoluteRootPath)) {
res.statusCode = 500;
res.end('Error: Detected directory traversal');
Expand Down