fix(ng-dev/pr): guard against null author in PR validations and checkout#3764
Open
josephperrott wants to merge 4 commits into
Open
fix(ng-dev/pr): guard against null author in PR validations and checkout#3764josephperrott wants to merge 4 commits into
josephperrott wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces null-safety checks for pull request authors across various validation scripts to prevent crashes, and adds a sanitization utility to redact sensitive URL credentials from child process logs, output, and errors. The reviewer feedback suggests improving the robustness of the child process error handler by sanitizing error messages before rejection, and recommends using more idiomatic TypeScript truthy checks instead of strict null checks for authors.
josephperrott
force-pushed
the
fix/sec-pr-null-author-dos-7e915aba
branch
from
3505754 to
de6095f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a Denial of Service vulnerability in PR validations and takeover checkout by adding guards for null author (deleted GitHub accounts). Vulnerability: 7e915aba