Fix overridden abbrev

[tmilnthorp]

Fixes #832

[codecov-commenter]

Codecov Report

❌ Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80%. Comparing base (ce7cc46) to head (5be4cf7).
⚠️ Report is 834 commits behind head on master.

Files with missing lines	Patch %	Lines
UnitsNet/CustomCode/UnitAbbreviationsCache.cs	94%	1 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##           master    #833   +/-   ##
======================================
  Coverage      80%     80%           
======================================
  Files         281     281           
  Lines       41925   41936   +11     
======================================
+ Hits        33770   33783   +13     
+ Misses       8155    8153    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[angularsen]

At first glance, I'm not sure about this union.

If you call GetUnitAbbreviations(typeof(LengthUnit), 1, russianCulture) then from this public method signature, isn't it unexpected to also receive English abbreviations?

[tmilnthorp]

A good question :) Should it? Currently you can get English abbreviations from GetUnitAbbreviations, but only if no Russian ones exist.

The parser obviously will not fall back without it. It's either that, or the parser logic will need to include the fallback logic. I wanted to keep everything contained.

[angularsen]

I'm really not sure. How about adding a new parameter bool includeFallbackCulture = false and call it with true from our own usages where we need to?

[angularsen]

I still think we should not do a union here indiscriminately. What do you think of my proposal of a new argument?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.