fix(app): reflect configured reasoning effort in web ui#17587
Open
kdybicz wants to merge 13 commits intoanomalyco:devfrom
Open
fix(app): reflect configured reasoning effort in web ui#17587kdybicz wants to merge 13 commits intoanomalyco:devfrom
kdybicz wants to merge 13 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17588
Type of change
What does this PR do?
The web UI did not reflect the reasoning/thinking effort configured through model options in
opencode.json.For configs like:
{ "provider": { "openai": { "models": { "gpt-5.4": { "options": { "reasoningEffort": "high" } } } } } }New sessions still showed the variant selector as
Default, and the first user message was sent without avariant. That also meant refresh could not preserve the selected thinking effort from session history.This change makes the app infer the UI variant from configured model options when no explicit session or agent variant is set. It matches the effective reasoning/thinking fields used by provider variants, so provider-added defaults like
reasoningSummarydo not block the mapping.This keeps the existing precedence intact:
Defaultstill overrides configured inferenceHow did you verify your code works?
bun test src/context/model-variant.test.tsinpackages/appbun typecheckinpackages/appbun run --conditions=browser ./src/index.ts serve --port 4096frompackages/opencodebun dev -- --port 4444frompackages/appHigheffort in the UI whenreasoningEffort: "high"is set in configScreenshots / recordings
Not added
Checklist
If you do not follow this template your PR will be automatically rejected.