fix: disable GPG signing in test fixtures#20386
Open
altendky wants to merge 1 commit intoanomalyco:devfrom
Open
fix: disable GPG signing in test fixtures#20386altendky wants to merge 1 commit intoanomalyco:devfrom
altendky wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Related PR FoundPR #18296: chore(app): QOL: don't sign commits during e2e tests Why it's related: This PR addresses the same underlying issue - disabling GPG/commit signing in tests. It appears to be a prior partial fix that focused on e2e tests. The current PR (20386) is a comprehensive follow-up that centralizes the configuration across all test fixtures and closes issue #18295 (likely related to PR 18296). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #20385
Closes #18295
Type of change
What does this PR do?
Adds
commit.gpgsign falseto all test fixtures that create temporary git repositories. This prevents test failures when developers have GPG/SSH signing agents configured globally.Previously, some tests used
--no-gpg-signflags on individual commit commands while others did not, causing inconsistent behavior. This fix centralizes the configuration in the fixtures so all commits in test repos inherit it automatically.Changes:
packages/opencode/test/fixture/fixture.ts- Added config totmpdir()andtmpdirScoped()packages/opencode/test/project/migrate-global.test.ts- Added config (manually inits git)packages/app/e2e/actions.ts- Added config tocreateTestProject()--no-gpg-signflags from test files that now inherit the settingHow did you verify your code works?
Ran all git-related unit tests with 1Password SSH agent configured: 145 pass, 13 skip, 0 fail.
Screenshots / recordings
N/A
Checklist