Add https to BrokerView restricted list#2073
Open
cshannon wants to merge 1 commit into
Open
Conversation
This adds https to the denied list eventhough there is currently no https discovery protocol. This is being done just for extra defense in depth in case a protocol is added in the future. There's also already other checks in place (we deny remote protocols by default already, etc) so this is just precautionary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds https to the denied list eventhough there is currently no https discovery protocol. This is being done just for extra defense in depth in case a protocol is added in the future. There's also already other checks in place (we deny remote protocols by default already, etc) so this is just precautionary.