Fix/add experiment refactor

[ash6898]

addresses #19347

Summary

Replace manual experiment list manipulation with the existing helper methods:

• Python: Convert experiments.append(...) to debug_options.add_experiment(...) in 5 files
• Java: Replace getExperiments()/modify/setExperiments() pattern with ExperimentalOptions.addExperiment(...) in 3 files

This is a pure refactor — no behavior change. The helper methods already handle null-init and deduplication internally.

Files changed

Python:

• sdks/python/apache_beam/pipeline.py
• sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
• sdks/python/apache_beam/io/iobase_test.py
• sdks/python/apache_beam/io/external/xlang_parquetio_test.py
• sdks/python/apache_beam/runners/dataflow/internal/apiclient.py

Java:

• runners/google-cloud-dataflow-java/src/main/java/.../DataflowPipelineTranslator.java
• runners/google-cloud-dataflow-java/src/main/java/.../DataflowRunner.java
• runners/google-cloud-dataflow-java/worker/src/main/.../GrpcWindmillServer.java

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a clean refactor of how pipeline experiments are managed in the codebase. By migrating from manual list operations to established helper methods, the implementation becomes more concise and robust, ensuring consistent handling of experiment flags without altering existing behavior.

Highlights

• Refactoring Experiment Management: Replaced manual list manipulation of pipeline experiments with centralized helper methods across both Python and Java SDKs.
• Improved Robustness: Utilized existing helper methods that inherently handle null-initialization and deduplication, reducing boilerplate and potential bugs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[ash6898]

CI Analysis

The Python CI failure (test_streaming_sentiment_analysis_yaml) is unrelated to this PR:

• Failing test location: apache_beam/yaml/examples/testing/examples_test.py (NOT in my changes)
• Root cause: gRPC subprocess server timeout in subprocess_server.py (infrastructure/environmental issue)
• My changes: Pure refactor of add_experiment() calls - zero behavioral impact
• Files modified:
  • sdks/python/apache_beam/pipeline.py
  • sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
  • sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
  • sdks/python/apache_beam/io/iobase_test.py
  • sdks/python/apache_beam/io/external/xlang_parquetio_test.py

None of these appear in the error trace. This is a pre-existing test infrastructure issue.

[damccorm]

assign set of reviewers

[github-actions]

Assigning reviewers:

R: @shunping for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[github-actions]

Reminder, please take a look at this pr: @shunping

[shunping]

Hi! Could you rebase your PR to the current master? Hopefully, that will reduce the number of failed tests.