fix: array_size returns -1 instead of null for null input#4578
Merged
Conversation
Contributor
|
Thanks @andygrove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4560.
Rationale for this change
array_size(NULL)should returnNULL, but Comet returned-1.array_sizeisRuntimeReplaceableand lowers toSize(child, legacySizeOfNull = false). WithlegacySizeOfNull = false, Spark returnsNULLfor aNULLinput; withlegacySizeOfNull = trueit returns-1.Comet's
Sizeserde built theelsebranch of itsCASE WHENfrom the session confSQLConf.get.legacySizeOfNullrather than from the expression's ownlegacySizeOfNullfield. Sincespark.sql.legacy.sizeOfNulldefaults totrue, theelseliteral became-1even thougharray_sizehad explicitly set the expression flag tofalse. The query runs natively viaCometProject, so it did not fall back: it just returned the wrong value.What changes are included in this PR?
CometSize.convertnow readsexpr.legacySizeOfNullinstead ofSQLConf.get.legacySizeOfNull. This honors the flag baked into eachSizeinstance, which already accounts for both thearray_sizeoverride (alwaysfalse) and the ANSI handling Spark applies when constructing the expression. The regularsizeandcardinalitypaths are unaffected because their expressions carry the resolved session value.How are these changes tested?
Added a test in
CometArrayExpressionSuiteassertingarray_sizereturnsNULLfor aNULLarray input under bothspark.sql.legacy.sizeOfNull=falseandtrue. The existingsize - respect to legacySizeOfNulltest continues to pass, confirming thesizepath is unchanged.