Skip to content

feat: implement native native existence join support#4587

Draft
coderfender wants to merge 6 commits into
apache:mainfrom
coderfender:feat_implement_native_existence_join
Draft

feat: implement native native existence join support#4587
coderfender wants to merge 6 commits into
apache:mainfrom
coderfender:feat_implement_native_existence_join

Conversation

@coderfender
Copy link
Copy Markdown
Contributor

@coderfender coderfender commented Jun 3, 2026

Which issue does this PR close?

Closes #3881 .

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@comphead comphead marked this pull request as draft June 4, 2026 01:19
Copy link
Copy Markdown
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coderfender this would also need to be tested by sql tests trying to cover as much edge cases as possible. Mark joins are pretty recently added in DF and might require extra testing

@coderfender
Copy link
Copy Markdown
Contributor Author

Absolutely agreed! Thank you for the review @comphead .

@coderfender coderfender changed the title feat: implement native existence join implementation feat: implement native native existence join support Jun 4, 2026
@coderfender
Copy link
Copy Markdown
Contributor Author

Mixed results with benches

Running benchmark: exists OR predicate (BHJ)
  Running case: Spark
  Stopped after 29 iterations, 2015 ms
  Running case: Comet
  Stopped after 61 iterations, 2011 ms

OpenJDK 64-Bit Server VM 17.0.16+8-LTS on Mac OS X 26.3.2
Apple M5 Pro
exists OR predicate (BHJ):                Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
Spark                                                43             70          15         24.4          41.1       1.0X
Comet                                                29             33           3         35.7          28.0       1.5X

Running benchmark: exists OR predicate (SHJ)
  Running case: Spark
  Stopped after 53 iterations, 2029 ms
  Running case: Comet
  Stopped after 44 iterations, 2043 ms

OpenJDK 64-Bit Server VM 17.0.16+8-LTS on Mac OS X 26.3.2
Apple M5 Pro
exists OR predicate (SHJ):                Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
Spark                                                35             38           2         29.7          33.7       1.0X
Comet                                                42             46           5         24.8          40.3       0.8X

Running benchmark: exists OR predicate (SMJ)
  Running case: Spark
  Stopped after 54 iterations, 2034 ms
  Running case: Comet
  Stopped after 35 iterations, 2019 ms

OpenJDK 64-Bit Server VM 17.0.16+8-LTS on Mac OS X 26.3.2
Apple M5 Pro
exists OR predicate (SMJ):                Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
Spark                                                35             38           2         29.8          33.6       1.0X
Comet                                                54             58           4         19.4          51.6       0.7X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ExistenceJoin support to Comet native execution

2 participants