Skip to content

chore: Fix clippy and CI#21287

Merged
comphead merged 2 commits intoapache:mainfrom
comphead:chore
Apr 3, 2026
Merged

chore: Fix clippy and CI#21287
comphead merged 2 commits intoapache:mainfrom
comphead:chore

Conversation

@comphead
Copy link
Copy Markdown
Contributor

@comphead comphead commented Mar 31, 2026

Which issue does this PR close?

  • Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added common Related to common crate execution Related to the execution crate physical-plan Changes to the physical-plan crate labels Mar 31, 2026
@comphead comphead changed the title chore: Fix clippy chore: Fix clippy and CI Mar 31, 2026
coderfender
coderfender approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderfender coderfender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comphead comphead mentioned this pull request Apr 2, 2026
Merged
jonahgao
jonahgao reviewed Apr 3, 2026
View reviewed changes
Cargo.toml Outdated
assigning_clones = "warn"
# ScalarValue and Expr contain Arc<..> with interior mutability but are
# intentionally used as hash keys throughout the codebase.
mutable_key_type = "allow"
Copy link
Copy Markdown
Member

@jonahgao jonahgao Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance we can allow this lint only for Expr and ScalarValue🤔

Copy link
Copy Markdown
Contributor Author

@comphead comphead Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checking that

jonahgao
jonahgao approved these changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate substrait Changes to the substrait crate functions Changes to functions implementation datasource Changes to the datasource crate spark labels Apr 3, 2026
@comphead
Copy link
Copy Markdown
Contributor Author

comphead commented Apr 3, 2026

Thanks @jonahgao and @alamb

@comphead comphead added this pull request to the merge queue Apr 3, 2026
Merged via the queue into apache:main with commit 777ecb8 Apr 3, 2026
35 checks passed
@comphead comphead deleted the chore branch April 3, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonahgao jonahgao jonahgao approved these changes

+1 more reviewer

@coderfender coderfender coderfender approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate execution Related to the execution crate functions Changes to functions implementation logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate spark sql SQL Planner substrait Changes to the substrait crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@comphead @coderfender @jonahgao