fix: Handle potential overflow in internal state for avg(decimal)#22714
Open
AdamGS wants to merge 1 commit into
Open
fix: Handle potential overflow in internal state for avg(decimal)#22714AdamGS wants to merge 1 commit into
avg(decimal)#22714AdamGS wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Fixes a bug with
avgthat currently prevents us from running TPC-DS q1. I think that this issues is masked by Parquet because the current implementations infers that columns as a Decimal128.What changes are included in this PR?
Rin sqllogictest, like the bigger decimal types, and fixes some tests that used?. (this can be a separate PR, but its seems very small).DecimalAvgAccumulatornow takes another type to hold its inner sum accumulator, which can be different than the input/output type.AVGimpl building blocks.Are these changes tested?
Additional SLT test that would've overflowed internally, and more focused unit tests for
AvgGroupsAccumulatorAre there any user-facing changes?
None, just more code that doesn't currently work and will work now.