feat: implement retract_batch for array_agg(DISTINCT) sliding window#22719
Open
SubhamSinghal wants to merge 1 commit into
Open
feat: implement retract_batch for array_agg(DISTINCT) sliding window#22719SubhamSinghal wants to merge 1 commit into
SubhamSinghal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
array_arg(DISTINCT x)in sliding window execution #22667.Rationale for this change
What changes are included in this PR?
rules (ignore_nulls skip, otherwise NULL is a tracked key).
multiplicities. Merged counts represent "partitions that emitted this value," which is fine because
evaluate only reads keys. Refcount semantics are only relied on within a single accumulator instance
(window execution, which doesn't merge).
Are these changes tested?
Yes
Are there any user-facing changes?
Yes. array_agg(DISTINCT x) now works in bounded/sliding window frames. Queries that previously
errored now succeed: