fix: preserve Spark next_day whitespace validation#22720
Open
xfocus3 wants to merge 1 commit into
Open
Conversation
Signed-off-by: xfocus3 <xfocus3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
next_daytrims whitespace from dayOfWeek; Spark does not #22717.Rationale for this change
Spark does not trim
dayOfWeekbefore matching it innext_day, butdatafusion-sparkcurrently does. That makes values like' MO 'succeed in DataFusion even though Spark treats them as invalid.What changes are included in this PR?
.trim()call fromspark_next_dayAre these changes tested?
cargo test -p datafusion-spark next_day_rejects_whitespace_padded_day_names -- --nocapturecargo test -p datafusion-sparkcargo fmt --all --checkcargo clippy -p datafusion-spark --all-targets --all-features --no-deps -- -D warningsNote: the broader package clippy invocation still reports an existing unused import warning in untouched
datafusion/core/src/execution/session_state.rson current main.Are there any user-facing changes?
Behavior now matches Spark for whitespace-padded
dayOfWeekinputs innext_day.