fix: make skip_partial_aggregation_probe_ratio_threshold match the docs#22752
Merged
Conversation
haohuaijin
changed the title
kosiew
approved these changes
Jun 5, 2026
Contributor
There was a problem hiding this comment.
@haohuaijin
Thanks for the fix. I do not see any blocking issues, just a couple of small suggestions that could make the regression coverage and config setup a bit clearer.
Contributor
Author
Contributor
Author
|
the failed ci should not related to my change, let me retrigger the ci to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The config
skip_partial_aggregation_probe_ratio_thresholdwas documented as triggering skip when the ratio is greater than the threshold, but the code used>=. This meant setting the threshold to1.0(to disable the feature) still skipped rows when cardinality was exactly 100%.What changes are included in this PR?
>=to>in the ratio comparison to match the docs.NoneforSkipAggregationProbewhenprobe_ratio_threshold >= 1.0, effectively disabling the feature since the ratio can never exceed1.0.Are these changes tested?
Yes. Added
test_skip_aggregation_disabled_at_threshold_onewhich sets threshold to1.0with 100% cardinality input and asserts that no rows are skipped.Are there any user-facing changes?
Yes. Setting
skip_partial_aggregation_probe_ratio_threshold = 1.0now reliably disables skip aggregation, matching the documented behavior.