[Fix][Function] Support 0 or negative max_limit for split_by_regexp function#64086
Open
XnY-wei wants to merge 1 commit into
Open
[Fix][Function] Support 0 or negative max_limit for split_by_regexp function#64086XnY-wei wants to merge 1 commit into
XnY-wei wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…it is applied
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
According to the official Apache Doris documentation, for the split_by_regexp function: "If max_limit is 0 or negative, no limit is applied."
However, the previous FE analyzer implementation strictly required the third parameter (max_limit) to be a positive constant. Passing 0 or a negative value threw an error: the third parameter of split_by_regexp function must be a positive constant.This PR relaxed the validation logic in the FE analyzer to allow 0 and negative constants for the max_limit parameter, aligning the implementation with the official documentation and expected behavior.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)