[refactor](be) Remove redundant casts from BE code#64087
Open
Mryange wants to merge 1 commit into
Open
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Remove redundant casts reported by clang-tidy readability-redundant-casting in BE code. These casts were no-op conversions to the same type, including redundant static_cast, reinterpret_cast, and C-style casts. The change keeps casts that still perform real type conversion and only removes the redundant outer casts reported by clang-tidy.
### Release note
None
### Check List (For Author)
- Test: Static analysis / Build
- Ran clang-tidy readability-redundant-casting on the modified BE files; no remaining readability-redundant-casting warnings were reported.
- Ran clang-format-16 on modified BE files.
- Ran git diff --check -- be/src.
- Ran sh build.sh --be -j48, build succeeded with "Successfully build Doris".
- Behavior changed: No
- Does this need documentation: No
Mryange
requested review from
Gabriel39,
gavinchou,
liaoxin01,
morningman and
yiguolei
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review result: no blocking issues found.
Critical checkpoint conclusions:
- Goal and tests: The PR is a narrow BE refactor to remove clang-tidy readability-redundant-casting findings. The changed sites accomplish that goal without observable semantic changes; the PR states clang-tidy, clang-format, diff check, and BE build were run.
- Scope and clarity: The modification is small and focused on redundant casts only.
- Concurrency and lifecycle: No new shared state, locks, threads, or lifecycle ownership changes were introduced.
- Configuration and compatibility: No new configuration, protocol, storage format, or function-symbol compatibility changes were introduced.
- Parallel code paths: The changes are mechanical across independent call sites; no functional path appears partially updated.
- Conditional checks and error handling: No new conditional checks or error-handling paths were introduced. The removed static_cast in ColumnVariant::finalize discards a void return, not a Status.
- Test coverage: No new functional tests are needed for this no-behavior refactor; build/static-analysis coverage is appropriate for this scope.
- Observability, transactions, and data writes: No logging/metrics, transaction, persistence, or data-write behavior changes were introduced.
- FE/BE variable passing: No transmitted variables or thrift/interface data paths were changed.
- Performance: No new allocations or redundant work were introduced; the changes are neutral.
Focus points: No additional user-provided review focus was specified.
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29328 ms |
Contributor
TPC-DS: Total hot run time: 169785 ms |
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: Remove redundant casts reported by clang-tidy readability-redundant-casting in BE code. These casts were no-op conversions to the same type, including redundant static_cast, reinterpret_cast, and C-style casts. The change keeps casts that still perform real type conversion and only removes the redundant outer casts reported by clang-tidy.
Release note
None
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)