Validate Connection: Upgrade on protocol switch responses#807
Open
arturobernalg wants to merge 1 commit intoapache:masterfrom
Open
Validate Connection: Upgrade on protocol switch responses#807arturobernalg wants to merge 1 commit intoapache:masterfrom
arturobernalg wants to merge 1 commit intoapache:masterfrom
Conversation
ok2c
requested changes
Apr 3, 2026
| } | ||
| } | ||
|
|
||
| private boolean containsConnectionUpgrade(final HttpMessage message) throws ProtocolException { |
Member
There was a problem hiding this comment.
@arturobernalg Use MessageSupport#parseHeaders or MessageSupport#parseTokens instead.
arturobernalg
force-pushed
the
protocol-switch-connection-upgrade
branch
2 times, most recently
from
225c915 to
b87b8fd
Compare
ProtocolSwitchStrategy now rejects 101 Switching Protocols responses that advertise Upgrade without the required Connection: Upgrade token.
arturobernalg
force-pushed
the
protocol-switch-connection-upgrade
branch
from
f5f29e9 to
be90817
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProtocolSwitchStrategy now rejects 101 Switching Protocols responses that advertise Upgrade without the required Connection: Upgrade token.
RFC 2817 notes:
"the upgrade keyword MUST be supplied within a Connection header field (section 14.10) whenever Upgrade is present in an HTTP/1.1 message". :contentReference[oaicite:0]{index=0}
RFC 9110 requires:
"A sender of Upgrade MUST also send an "Upgrade" connection option in the Connection header field (Section 7.6.1)". :contentReference[oaicite:1]{index=1}