fix: forward idempotency_key, ignore_ssl_errors and do_not_retry for ad-hoc webhooks#854
Closed
vdusek wants to merge 2 commits into
Closed
fix: forward idempotency_key, ignore_ssl_errors and do_not_retry for ad-hoc webhooks#854vdusek wants to merge 2 commits into
vdusek wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #854 +/- ##
==========================================
- Coverage 94.82% 94.58% -0.24%
==========================================
Files 48 48
Lines 5045 5063 +18
==========================================
+ Hits 4784 4789 +5
- Misses 261 274 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ad-hoc webhooks passed to
start()/call()silently droppedidempotency_key,ignore_ssl_errorsanddo_not_retry.WebhookRepresentationdeclared only the four templating fields, andencode_webhooks_to_base64keeps only declared fields, so these three never reached the platform. The platform accepts and honors all three for ad-hoc webhooks (verified in apify-core: the run-start handler feeds them into the same webhook-creation path as the create-webhook endpoint, including theidempotencyKeydedup).What changed:
WebhookRepresentationand both webhook-representation typed dicts (snake_case + camelCase).WebhookCreate/ dict projection inencode_webhooks_to_base64to filter by the fieldsWebhookRepresentationdeclares, instead of hand-listing them. New ad-hoc fields now flow through automatically, so this class of silent-drop bug cannot recur.This PR updates the auto-generated Pydantic models and TypedDicts based on OpenAPI specification changes in apify-docs PR #2640.
Supersedes #855 (the auto-regeneration of the same model changes).
Unblocks apify/apify-sdk-python#963, which forwards these fields from the SDK
Webhookdataclass.