fix: remove double usage_count increment in Session.retire()

[vdusek]

Summary

• Session.retire() incremented _usage_count, but callers (mark_good(), mark_bad()) already increment it before calling retire(), causing a double-increment when a session is retired at the usage limit.
• Removed the redundant _usage_count += 1 from retire().
• Added tests covering the no-double-increment invariant for mark_good(), mark_bad(), and direct retire() calls.

Test plan

• Existing session tests pass
• New tests verify usage_count is incremented exactly once per mark_good()/mark_bad() call, even when retirement is triggered

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.24%. Comparing base (02a18ea) to head (3d72b64).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1816   +/-   ##
=======================================
  Coverage   92.23%   92.24%           
=======================================
  Files         157      157           
  Lines       10863    10881   +18     
=======================================
+ Hits        10020    10037   +17     
- Misses        843      844    +1     

Flag	Coverage Δ
unit	92.24% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Mantisus]

LGTM

[Pijukatel]

What if someone retires a session explicitly by directly calling session.retire()?

While ugly, I think it would be safer to avoid the increment in the branches that call the retire. Something like:

    def mark_bad(self) -> None:
        """Mark the session as bad after an unsuccessful session usage."""
        self._error_score += 1

        # Retire the session if it is not usable anymore
        if not self.is_usable:
            self.retire()
        else:
            self._usage_count += 1

[Pijukatel]

What if someone retires a session explicitly by directly calling session.retire()?

While ugly, I think it would be safer to avoid the increment in the branches that call the retire. Something like:

    def mark_bad(self) -> None:
        """Mark the session as bad after an unsuccessful session usage."""
        self._error_score += 1

        # Retire the session if it is not usable anymore
        if not self.is_usable:
            self.retire()
        else:
            self._usage_count += 1

Actually, it does not matter. You can ignore this comment