Skip to content

fix(file-system): Reclaim orphaned in-progress requests on RQ recovery#1825

Merged
vdusek merged 1 commit intomasterfrom
fix/reclaim-in-progress-requests-on-recovery
Mar 31, 2026
Merged

fix(file-system): Reclaim orphaned in-progress requests on RQ recovery#1825
vdusek merged 1 commit intomasterfrom
fix/reclaim-in-progress-requests-on-recovery

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented Mar 30, 2026

Summary

  • When a process crashed after fetch_next_request but before mark_request_as_handled or reclaim_request, the request remained in persisted in_progress_requests and was silently skipped on restart
  • Clear in_progress_requests during _discover_existing_requests so orphaned requests are retried
  • Add unit test simulating the crash-recovery scenario

Test plan

  • New test test_in_progress_requests_recovered_after_crash validates the fix
  • All existing storage client tests pass
  • Lint and type checks pass

🤖 Generated with Claude Code

When a process crashed after fetching a request but before marking it as
handled or reclaiming it, the request was stuck in in_progress_requests
and silently lost on restart. Now _discover_existing_requests clears
in_progress_requests on startup so all orphaned requests are retried.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Mar 30, 2026
@vdusek vdusek self-assigned this Mar 30, 2026
@github-actions github-actions bot added this to the 137th sprint - Tooling team milestone Mar 30, 2026
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Mar 30, 2026
@vdusek vdusek changed the title fix: reclaim orphaned in-progress requests on file system RQ recovery fix(file-system): Reclaim orphaned in-progress requests on RQ recovery Mar 30, 2026
@vdusek vdusek requested a review from Pijukatel March 30, 2026 13:21
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.31%. Comparing base (5b28f03) to head (580fde0).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1825      +/-   ##
==========================================
+ Coverage   92.25%   92.31%   +0.05%     
==========================================
  Files         157      157              
  Lines       10886    10889       +3     
==========================================
+ Hits        10043    10052       +9     
+ Misses        843      837       -6     
Flag Coverage Δ
unit 92.31% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@Mantisus Mantisus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit e86794a into master Mar 31, 2026
32 checks passed
@vdusek vdusek deleted the fix/reclaim-in-progress-requests-on-recovery branch March 31, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants