Skip to content

test: Mark flaky Stagehand fingerprint headers test for retries on Windows#1902

Merged
vdusek merged 1 commit into
masterfrom
fix/flaky-stagehand-fingerprint-headers-test
May 19, 2026
Merged

test: Mark flaky Stagehand fingerprint headers test for retries on Windows#1902
vdusek merged 1 commit into
masterfrom
fix/flaky-stagehand-fingerprint-headers-test

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented May 19, 2026

Summary

tests/unit/browsers/test_stagehand_browser_controller.py::test_fingerprint_headers_set_on_new_page occasionally fails on Windows runners with playwright._impl._errors.Error: StagehandPage.goto: net::ERR_NO_BUFFER_SPACE (see this run). This is the known Windows-only resource flake that already affects parallel Playwright tests under xdist load — the runner exhausts socket buffer space.

Following the same mitigation pattern already used in test_adaptive_playwright_crawler.py:240, the test is now marked @pytest.mark.flaky(rerun=3, ...) so transient ERR_NO_BUFFER_SPACE failures are retried instead of breaking CI.

…ndows

The test occasionally fails on Windows runners with
net::ERR_NO_BUFFER_SPACE under xdist parallelism, matching the
known Windows-only resource flake already mitigated elsewhere.
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels May 19, 2026
@vdusek vdusek self-assigned this May 19, 2026
@github-actions github-actions Bot added this to the 141st sprint - Tooling team milestone May 19, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.86%. Comparing base (c3a58e7) to head (bd8d120).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1902      +/-   ##
==========================================
- Coverage   92.88%   92.86%   -0.02%     
==========================================
  Files         167      167              
  Lines       11709    11709              
==========================================
- Hits        10876    10874       -2     
- Misses        833      835       +2     
Flag Coverage Δ
unit 92.86% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek merged commit a7598f0 into master May 19, 2026
33 checks passed
@vdusek vdusek deleted the fix/flaky-stagehand-fingerprint-headers-test branch May 19, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants