Show "ESC to detach" hint immediately in spinner#135
Open
Conversation
The hint was gated on capturedTaskId being set, which only happens after the server sends a taskCreated event. Moved the ESC listener setup before the spinner and compute the hint text once upfront so it appears immediately when the spinner starts. https://claude.ai/code/session_01WPrQYz1Qru8M6ARkaAga39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moved the ESC key listener setup earlier in the tool execution flow so that the "ESC to detach" hint displays immediately in the spinner, rather than waiting for the server to return a task ID.
Key Changes
setupEscListener()call to execute before spinner initializationescHintText) into a variable that's computed once based on listener availabilityupdateSpinnerText()to use the pre-computedescHintTextinstead of conditionally computing it on each updateImplementation Details
The hint text is now determined upfront based on whether an ESC listener promise exists, rather than being recalculated in the spinner update loop with an additional check for
capturedTaskId. This provides immediate visual feedback to users that they can press ESC to detach, without waiting for the task ID to be captured from the server response.https://claude.ai/code/session_01WPrQYz1Qru8M6ARkaAga39