Skip to content

LinuxContainer/LinuxPod: Sort mounts by depth#601

Merged
dcantah merged 1 commit intoapple:mainfrom
dcantah:sort-mounts
Apr 3, 2026
Merged

LinuxContainer/LinuxPod: Sort mounts by depth#601
dcantah merged 1 commit intoapple:mainfrom
dcantah:sort-mounts

Conversation

@dcantah
Copy link
Copy Markdown
Member

@dcantah dcantah commented Mar 27, 2026

To avoid a user accidentally shadowing a mount, we can sort mounts by depth (but stable sort so mounts of the same depth stay in the order provided).

Comment thread Sources/Containerization/LinuxContainer.swift
Copy link
Copy Markdown
Contributor

@manojmahapatra manojmahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To avoid a user accidentally shadowing a mount, we can sort
mounts by depth (but stable sort so mounts of the same depth
stay in the order provided). We should normalize as well.
@dcantah dcantah merged commit 3c42157 into apple:main Apr 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants