Skip to content

feat: Command Line SDK update for version 19.0.0#302

Merged
ChiragAgg5k merged 4 commits intomasterfrom
dev
Apr 23, 2026
Merged

feat: Command Line SDK update for version 19.0.0#302
ChiragAgg5k merged 4 commits intomasterfrom
dev

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

@ChiragAgg5k ChiragAgg5k commented Apr 22, 2026

This PR contains updates to the Command Line SDK for version 19.0.0.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 22, 2026

Greptile Summary

This PR bumps the CLI SDK to v19.0.0, upgrades the @appwrite.io/console dependency to v11.0.0, and migrates auth-security project settings from projectsService to the new projectService API. It also refactors the deployment timeout mechanism from a fixed deadline to an activity-based tracker, introduces a PR-based Homebrew tap update workflow, and adds a user-selectable local path and optional template download to the site init flow.

Confidence Score: 4/5

Safe to merge after confirming the previously flagged updateMockNumbers/updateAuthStatus asymmetry is intentional; all other changes are well-structured.

The previously flagged P1 concern (updateMockNumbers/updateAuthStatus still calling projectsService while all other security settings were migrated) remains unresolved in this diff. Both methods still exist in projects.ts so no runtime crash is expected, but the asymmetry is worth a deliberate author sign-off. All other changes — timeout tracker refactor, Homebrew PR workflow, site path question, config field pruning — look correct.

lib/commands/push.ts lines 1053–1066: updateMockNumbers and updateAuthStatus still call projectsService while every other auth security setting was migrated to projectService in this PR.

Important Files Changed

Filename Overview
lib/commands/push.ts Migrates most auth security calls from projectsService to projectService; updateMockNumbers and updateAuthStatus still call the old projectsService (both methods remain in projects.ts). Adds activity-based deployment timeout tracker; removes fixed-deadline + screenshot extension in favour of progress signals. Drops enabled field from site update payloads.
.github/workflows/publish.yml Replaces direct push to Homebrew tap with a checkout → update formula → open PR flow; uses force-push to release branch (safe for automation); requires new HOMEBREW_TAP_GH_TOKEN secret.
lib/constants.ts Bumps SDK_VERSION to 19.0.0; adds HOMEBREW_TAP and HOMEBREW_FORMULA constants (appwrite/appwrite/appwrite — correct fully-qualified tap reference).
lib/commands/init.ts Site init now accepts a user-provided path and optional template download; cleanup logic uses createdSiteDir guard; non-downloadTemplate path has no cleanup if an error occurs after directory creation.
lib/commands/update.ts Switches hard-coded appwrite formula string to HOMEBREW_FORMULA constant and EXECUTABLE_NAME in hint messages.
lib/config.ts getSites() now strips deprecated fields (enabled, vars, ignore) on read; getSite() delegates to getSites() for consistency.
lib/questions.ts Adds path and downloadTemplate questions to the site creation flow; path defaults to sites/ and validates the target isn't a file.
lib/commands/services/projects.ts Several commands removed (update-auth-duration, update-auth-limit, etc.) that were migrated to project service; updateMockNumbers and updateAuthStatus commands remain.

Reviews (4): Last reviewed commit: "chore: update Command Line SDK to 19.0.0" | Re-trigger Greptile

Comment thread .github/workflows/publish.yml
Comment thread lib/commands/init.ts
@ChiragAgg5k ChiragAgg5k merged commit 5388d42 into master Apr 23, 2026
2 checks passed
@ChiragAgg5k ChiragAgg5k deleted the dev branch April 23, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants