Avoid-Logging-Known-User-Errors-To-Sentry-And-Amplitude#1614
Open
teg-atlassian wants to merge 1 commit intomainfrom
Open
Avoid-Logging-Known-User-Errors-To-Sentry-And-Amplitude#1614teg-atlassian wants to merge 1 commit intomainfrom
teg-atlassian wants to merge 1 commit intomainfrom
Conversation
teg-atlassian
requested review from
BHulovatyi,
Blastoplex,
amarg-at,
bwieger-atlassian-com,
cabella-dot,
ccallcottstevens,
dchiew-atl,
jwang19-atlassian,
marcomura,
matt-lassian,
mattcolman,
om-ukr,
sdzh-atlassian and
sky-ocean-spirits
as code owners
teg-atlassian
changed the title
teg-atlassian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Is This Change?
This PR removes one type of error from being logged to Amplitude and Sentry.
These are user errors rovodev reports to atlascode By user error we mean, it is up to the user to fix by taking appropriate action such as having a site have rovo dev installed as an app. We, in other PRs, handles these errors gracefully and let the user knows what they need to do. However, In such cases, we don't need to log them to our analytics systems such as Amplitude and Sentry. This PR filters out those user errors from errors that are logged in to Amplitude and Sentry. This PR also refactors the code so that we can avoid redundant code.
How Has This Been Tested?
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations:
Upgrade to Rovo Dev Standard to continue using code review.