AXON-1968: Support file picker in chat#1758
Open
jwang19-atlassian wants to merge 15 commits intomainfrom
Open
Conversation
Contributor
|
The issue is ready for review. The below acceptance criteria have not been met:
|
![atlassian[bot]](https://avatars.githubusercontent.com/in/14320?s=60&v=4){kind=small}
jwang19-atlassian
requested review from
asifmujteba,
bwieger-atlassian-com,
cabella-dot,
marcomura,
om-ukr,
sdzh-atlassian,
ssinha2598 and
teg-atlassian
as code owners
jwang19-atlassian
requested review from
BHulovatyi,
Blastoplex,
amarg-at,
ccallcottstevens,
cindy-atl,
dchiew-atl,
matt-lassian,
mattcolman and
sky-ocean-spirits
as code owners
| files = [{ name: 'Initializing...', path: '' }]; | ||
| } else { | ||
| // Show loading state while fetching | ||
| if (!files.length) { |
Contributor
There was a problem hiding this comment.
🔥 Code Bugs
The loading state check files.length will always be falsy for the initial empty array, causing the loading message to be overwritten immediately.
Details
📖 Explanation: This condition prevents the loading message from being displayed properly, as the empty array check happens before the async fetch completes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Is This Change?
https://www.loom.com/share/565d3e5f1c0d47229aeeafc92fcc9245
This PR adds file pickers autocomplete functionality to Rovo Dev chat prompt. Users can now type
#to search and select workspace files, which are automatically attached as context to the chatHow Has This Been Tested?
Basic checks:
npm run lintnpm run testRovo Dev code review: Rovo Dev is reviewing this pull request…
Refresh the page in a few minutes to see the results.