feat: aurora connection tracker plugin by gagan-kaur786 · Pull Request #250 · aws/aws-advanced-dotnet-data-provider-wrapper

gagan-kaur786 · 2026-03-09T19:40:08Z

Summary

feat: add aurora connection tracker plugin

Description

Adds the aurora connection tracker plugin. This plugin tracks all the opened connections. In the event of a cluster failover, this plugin will close all the impacted connections. If no plugins are explicitly specified, this plugin is enabled by default.

Additional Reviewers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…er-wrapper into feat/aurora-connection-tracker

…and OpenedConnectionTracker - Wire AuroraConnectionTrackerPluginFactory in ConnectionPluginChainBuilder - Implement AuroraConnectionTrackerPlugin constructor, fields, and SubscribedMethods - Create OpenedConnectionTracker with static tracking map, singleton background pruning task, PruneNullConnections, and ClearCache

…nnectionTracker

… class

…a-provider-wrapper into feat/aurora-connection-tracker

… Tracker plugin

Copilot

Pull request overview

This PR implements the Aurora Connection Tracker Plugin for the .NET AWS wrapper. It tracks all opened database connections keyed by RDS instance endpoint and aliases (when no RDS instance endpoint is found) and closes stale connections to the old writer after a cluster failover, preventing applications from accidentally using connections that now point to a reader.

Changes:

New AuroraConnectionTrackerPlugin and OpenedConnectionTracker classes providing connection lifecycle interception and thread-safe tracking
Plugin registration in ConnectionPluginChainBuilder and PluginCodes
Supporting spec docs (requirements and design) and resource strings for logging

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`AuroraConnectionTrackerPlugin.cs`	Core plugin: intercepts open/execute/close to track connections and detect writer changes
`OpenedConnectionTracker.cs`	Thread-safe tracking map; handles populate, invalidate, remove, and background pruning
`AuroraConnectionTrackerPluginFactory.cs`	Factory that creates plugin instances
`ConnectionPluginChainBuilder.cs`	Registers the new plugin factory and assigns execution weight 400
`PluginCodes.cs`	Adds the `"auroraConnectionTracker"` plugin code constant
`Resources.resx`	Adds localized log/error message strings for the tracker
`requirements.md`	Spec requirements document for the feature
`design.md`	Detailed design document including architecture, data models, and testing strategy

Files not reviewed (1)

AwsWrapperDataProvider/Properties/Resources.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTracker.cs

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/AuroraConnectionTrackerPlugin.cs

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTracker.cs

.kiro/specs/dotnet-aurora-connection-tracker/design.md

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTracker.cs

…r testability

…r786/aws-advanced-dotnet-data-provider-wrapper into feat/aurora-connection-tracker

…er-wrapper into feat/aurora-connection-tracker

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTracker.cs

karenc-bq · 2026-03-17T19:38:09Z

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTracker.cs

+            try
+            {
+                string cleanHost = RdsUtils.RemovePort(key);
+                if (!RdsUtils.IsRdsInstance(cleanHost))


We should try to see if this host is tracked regardless, in case it is a custom endpoint

Yes, will be updated as part of tracking custom endpoints change.

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTracker.cs

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/AuroraConnectionTrackerPlugin.cs

...rDataProvider/Driver/Plugins/AuroraConnectionTracker/AuroraConnectionTrackerPluginFactory.cs

…prove host tracking

…up and failure simulation

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/AuroraConnectionTrackerPlugin.cs

AwsWrapperDataProvider/Driver/Utils/RWQueue.cs

kenrickyap · 2026-03-24T18:54:06Z

Let's make sure the existing integration test is passing and that we fix the existing linting errors

… field names

…parameters

…state cleanup

…er-wrapper into feat/aurora-connection-tracker

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/AuroraConnectionTrackerPlugin.cs

kenrickyap

minor nits, LGTM

AwsWrapperDataProvider.Dialect.MySqlClient/MySqlClientDialect.cs

AwsWrapperDataProvider.Dialect.MySqlConnector/MySqlConnectorDialect.cs

...perDataProvider.Tests/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTrackerTests.cs

karenc-bq · 2026-03-26T22:10:03Z

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTracker.cs

+    /// <param name="connection">The database connection to track.</param>
+    public void PopulateOpenedConnectionQueue(HostSpec hostSpec, DbConnection connection)
+    {
+        EnsurePruneLoopRunning();


Do we need this verification here if we already have it in the constructor?

This is kept for two potential cases: (1) if the background prune task faults unexpectedly and silently dies, or (2) ReleaseResources() is called but the same tracker instance continues to be used, the constructor won't re-run, so the loop stays dead. This check ensures that every time we track a new connection, we verify the loop is still running and restart it if needed. The cost is negligible- one lock check per connection open.

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTracker.cs

karenc-bq · 2026-03-27T00:35:55Z

AwsWrapperDataProvider/Driver/Plugins/ConnectionPluginChainBuilder.cs

    {
            { PluginCodes.ConnectTime, new Lazy<IConnectionPluginFactory>(() => new ConnectTimePluginFactory()) },
            { PluginCodes.ExecutionTime, new Lazy<IConnectionPluginFactory>(() => new ExecutionTimePluginFactory()) },
+            { PluginCodes.AuroraConnectionTracker, new Lazy<IConnectionPluginFactory>(() => new AuroraConnectionTrackerPluginFactory()) },


I think this particular list follows the alphabetical order

Not really. But I've updated the sequence to match plugin weights order, same as in PluginWeightByPluginFactoryType.

…lization sequence to match plugin weight

gagan-kaur786 added 11 commits February 13, 2026 22:32

feat: aurora connection tracker plugin initial commit

6e220ad

Merge branch 'main' of github.com:aws/aws-advanced-dotnet-data-provid…

2ff2cfe

…er-wrapper into feat/aurora-connection-tracker

feat(auroraConnectionTracker): add aurora connection tracker plugin code

d588184

feat: add connection tracking and RDS endpoint resolution to OpenedCo…

ab1dda9

…nnectionTracker

feat: add remove connection tracking logic to OpenedConnectionTracker…

38b941b

… class

feat: add invalidate connections logic to OpenedConnectionTracker class

00d965e

Merge branch 'main' of https://github.com/aws/aws-advanced-dotnet-dat…

7e8f876

…a-provider-wrapper into feat/aurora-connection-tracker

feat: add open connection and execute logic to the Aurora Connection…

83f83d4

… Tracker plugin

feat: enable logging OpenedConnections queue contents

e1346d5

fix: remove stale connection tracker plugin class

91dd871

Copilot AI review requested due to automatic review settings March 9, 2026 19:40

gagan-kaur786 marked this pull request as draft March 9, 2026 19:40

Copilot started reviewing on behalf of gagan-kaur786 March 9, 2026 19:40 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

faviansamatha reviewed Mar 9, 2026

View reviewed changes

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTracker.cs Outdated Show resolved Hide resolved

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTracker.cs Show resolved Hide resolved

gagan-kaur786 added 7 commits March 11, 2026 17:37

refactor(connection-tracker): extract IConnectionTracker interface fo…

c48286b

…r testability

Merge branch 'feat/aurora-connection-tracker' of github.com:gagan-kau…

18b9efa

…r786/aws-advanced-dotnet-data-provider-wrapper into feat/aurora-connection-tracker

Merge branch 'main' of github.com:aws/aws-advanced-dotnet-data-provid…

08277b0

…er-wrapper into feat/aurora-connection-tracker

test: add unit tests for the AuroraConnectionTrackerPlugin class

299d110

test: add unit tests for the OpenedConnectionTracker class

2d447c3

Merge branch 'main' of github.com:aws/aws-advanced-dotnet-data-provid…

4ab46ab

…er-wrapper into feat/aurora-connection-tracker

Remove spec files from tracking

b487693

karenc-bq reviewed Mar 17, 2026

View reviewed changes

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTracker.cs Outdated Show resolved Hide resolved

karenc-bq reviewed Mar 17, 2026

View reviewed changes

test: add aurora connection tracker integration test with failover

203411f

karenc-bq reviewed Mar 17, 2026

View reviewed changes

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTracker.cs Outdated Show resolved Hide resolved

karenc-bq reviewed Mar 17, 2026

View reviewed changes

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/AuroraConnectionTrackerPlugin.cs Outdated Show resolved Hide resolved

karenc-bq reviewed Mar 17, 2026

View reviewed changes

...rDataProvider/Driver/Plugins/AuroraConnectionTracker/AuroraConnectionTrackerPluginFactory.cs Outdated Show resolved Hide resolved

test(OpenedConnectionTracker): add unit tests for connection management

11d8bbd

refactor(AuroraConnectionTracker): simplify exception handling and im…

7d29687

…prove host tracking

gagan-kaur786 marked this pull request as ready for review March 19, 2026 17:41

gagan-kaur786 added 2 commits March 22, 2026 23:51

test(FailoverConnectivityTests): add delay for TCP connection severance

928a90e

test(FailoverConnectivityTests): use instance info for connection set…

abe3e18

…up and failure simulation

kenrickyap reviewed Mar 23, 2026

View reviewed changes

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/AuroraConnectionTrackerPlugin.cs Show resolved Hide resolved

kenrickyap reviewed Mar 23, 2026

View reviewed changes

AwsWrapperDataProvider/Driver/Utils/RWQueue.cs Show resolved Hide resolved

gagan-kaur786 added 7 commits March 24, 2026 13:05

test(FailoverConnectivityTests): use RDS API to determine cluster writer

2eacb9e

docs(plugins): add Aurora Connection Tracker Plugin documentation

cfc0eeb

style(AuroraConnectionTracker): remove leading underscore from static…

d08209e

… field names

docs(AuroraConnectionTracker,RWQueue): add missing XML documentation …

5bc9457

…parameters

test(AuroraConnectionTrackerPluginTests): update field name references

8e74819

test(AuroraConnectionTrackerPluginTests): add try-finally blocks for …

30cf562

…state cleanup

Merge branch 'main' of github.com:aws/aws-advanced-dotnet-data-provid…

002069c

…er-wrapper into feat/aurora-connection-tracker

kenrickyap reviewed Mar 26, 2026

View reviewed changes

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/AuroraConnectionTrackerPlugin.cs Outdated Show resolved Hide resolved

kenrickyap reviewed Mar 26, 2026

View reviewed changes

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/AuroraConnectionTrackerPlugin.cs Outdated Show resolved Hide resolved

kenrickyap approved these changes Mar 26, 2026

View reviewed changes

gagan-kaur786 added 2 commits March 26, 2026 14:14

fix: remove unnecessary null check

0152825

test(AuroraConnectionTrackerPluginTests): remove null connection test

4d4a96f

karenc-bq reviewed Mar 26, 2026

View reviewed changes

AwsWrapperDataProvider.Dialect.MySqlClient/MySqlClientDialect.cs Outdated Show resolved Hide resolved

karenc-bq reviewed Mar 26, 2026

View reviewed changes

AwsWrapperDataProvider.Dialect.MySqlConnector/MySqlConnectorDialect.cs Outdated Show resolved Hide resolved

karenc-bq reviewed Mar 26, 2026

View reviewed changes

...perDataProvider.Tests/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTrackerTests.cs Outdated Show resolved Hide resolved

karenc-bq reviewed Mar 26, 2026

View reviewed changes

AwsWrapperDataProvider/Driver/Plugins/AuroraConnectionTracker/OpenedConnectionTracker.cs Outdated Show resolved Hide resolved

karenc-bq approved these changes Mar 26, 2026

View reviewed changes

karenc-bq reviewed Mar 27, 2026

View reviewed changes

gagan-kaur786 added 4 commits March 27, 2026 10:33

refactor: reorder default plugin execution sequence by weight

4b1f428

refactor(ConnectionPluginChainBuilder): reorder plugin factory initia…

31ec907

…lization sequence to match plugin weight

test(OpenedConnectionTracker): remove unused ClearCache test and method

d7b1cab

fix(OpenedConnectionTracker): fix linting

f8ff451

Conversation

gagan-kaur786 commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Description

Additional Reviewers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Uh oh!

Copilot AI left a comment • edited by gagan-kaur786 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

karenc-bq Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gagan-kaur786 Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

gagan-kaur786 Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kenrickyap commented Mar 24, 2026

Uh oh!

Uh oh!

Uh oh!

kenrickyap left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

karenc-bq Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

gagan-kaur786 Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

karenc-bq Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

gagan-kaur786 Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gagan-kaur786 commented Mar 9, 2026 •

edited

Loading

Copilot AI left a comment •

edited by gagan-kaur786

Loading

karenc-bq Mar 17, 2026 •

edited

Loading