Add per-service CLI flags for client context params#10166
Open
AndrewAsseily wants to merge 3 commits intov2from
Open
Add per-service CLI flags for client context params#10166AndrewAsseily wants to merge 3 commits intov2from
AndrewAsseily wants to merge 3 commits intov2from
Conversation
…s to S3 (5 params) and S3Control (1 param).
ashovlin
requested changes
Mar 31, 2026
Member
There was a problem hiding this comment.
I haven't done a full pass on the code yet, but stepping through this in a debugger I am NOT seeing the new parameters influencing the endpoint rules with a breakpoint at EndpointProvider->resolve_endpoint.
aws s3api list-objects-v2 --bucket <mrap arn> --disable-multi-region-access-points is still working for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
This exposes clientContextParams from the service model as per-service CLI flags. Currently that's S3 (5 params) and S3Control (1 param). The existing s3 config values still take priority.
Added model validation tests for name collisions between client context params and operation input members, and for unsupported param types (currently only string and boolean are supported).
Changelog type: I used enhancement since the underlying plumbing already exists in and this is just surfacing it in the CLI.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.