fix(lib-dynamodb): conditionally clone middleware stack when cacheMiddleware is enabled#7801
Open
TrevorBurnham wants to merge 1 commit intoaws:mainfrom
Open
Conversation
…dleware is enabled When cacheMiddleware: true is set on the parent DynamoDBClient, the document client now clones the middleware stack at construction time. This prevents cached handlers from going stale due to shared-stack mutations. When cacheMiddleware is false (the default), the existing shared-reference behavior is preserved, ensuring full backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously: #7762
Currently, setting
cacheMiddleware: trueonDynamoDBDocumentClientcauses a runtime error.With this PR, that setting causes the middleware stack from the parent to be cloned, allowing it to be cached. When
cacheMiddlewareisfalse(the default), the existing shared-reference behavior is preserved.Checklist
*.integ.spec.ts) or E2E tests.@public,@internaltags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.