fix: Replace HMAC with SHA based integrity checks in model builder.#5656
Open
pravali96 wants to merge 1 commit intoaws:master-v2from
Open
fix: Replace HMAC with SHA based integrity checks in model builder.#5656pravali96 wants to merge 1 commit intoaws:master-v2from
pravali96 wants to merge 1 commit intoaws:master-v2from
Conversation
pravali96
force-pushed
the
fix/triton-hmac-security-v2-all-bugs
branch
from
6e9283e to
8fe96c8
Compare
pravali96
force-pushed
the
fix/triton-hmac-security-v2-all-bugs
branch
from
c8d05ec to
079e1f2
Compare
pravali96
changed the title
pravali96
changed the title
nargokul
requested changes
Mar 31, 2026
Contributor
nargokul
left a comment
nargokul
left a comment
There was a problem hiding this comment.
Please fix integ test failures.
| metadata.write(_MetaData(hash_value).to_json()) | ||
|
|
||
| return secret_key | ||
| return "" |
Contributor
There was a problem hiding this comment.
Nit: We need not return anything here
Collaborator
Author
There was a problem hiding this comment.
The 11 failing tests are in JumpStart, not model builder. They are unrelated to these changes. is that a blocker?
Collaborator
Author
There was a problem hiding this comment.
it's not needed for long-term but its better to keep return "" for backward compatibility in this security fix. Callers (self.secret_key = prepare_for_mms(...)) still assign this return value, so it cannot be none.
gwang111
approved these changes
Mar 31, 2026
pravali96
force-pushed
the
fix/triton-hmac-security-v2-all-bugs
branch
2 times, most recently
from
079e1f2 to
334346a
Compare
pravali96
force-pushed
the
fix/triton-hmac-security-v2-all-bugs
branch
from
95dc333 to
a809727
Compare
…y check (v2) Backport of v3 security fixes for P400136088 and V2146375387. 1. check_integrity.py: Switch from HMAC-SHA256 to plain SHA-256. Remove generate_secret_key, remove env var dependency. 2. triton/model.py: Add integrity check in initialize() BEFORE cloudpickle deserialization. 3. triton/server.py: Remove SAGEMAKER_SERVE_SECRET_KEY from container environment variables. 4. triton/triton_builder.py: Remove hardcoded dummy secret key for ONNX path. Rename _hmac_signing to _compute_integrity_hash. Use plain SHA-256. 5. All prepare.py files (torchserve, mms, tf_serving, smd): Remove generate_secret_key usage, switch to plain SHA-256.
pravali96
force-pushed
the
fix/triton-hmac-security-v2-all-bugs
branch
from
032f58f to
d10bf43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Replace HMAC with SHA based integrity checks in model builder.
Issue
Fix
Switch from HMAC-SHA256 (requires a secret key) to plain SHA-256 (no key needed)
Changes
check_integrity.pygenerate_secret_key()— no longer neededcompute_hash()now useshashlib.sha256()instead ofhmac.new()perform_integrity_check()no longer readsSAGEMAKER_SERVE_SECRET_KEYfrom environmentBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.