fix: Pipeline TypeError: can only concatenate list (not "NoneType") to list Using Sou (#5518)#5678
Closed
aviruthen wants to merge 1 commit intoaws:masterfrom
Conversation
…o list Using Sou (aws#5518)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bug occurs in
get_code_hash()->get_training_code_hash()insagemaker-core/src/sagemaker/core/workflow/utilities.py. When aSourceCodeobject is created without specifyingrequirements(which defaults toNone), theget_code_hash()function readssource_code.requirements(which isNone) and passes it as thedependenciesparameter toget_training_code_hash(). In the user's installed version (3.3.1), the function directly does[source_dir] + dependencieswheredependenciesisNone, causingTypeError: can only concatenate list (not "NoneType") to list. The fix already exists in the current repo HEAD: theget_training_code_hash()function now guards againstNonedependencies by checkingif dependencies:before concatenation, and wraps the single string value in a list[dependencies]rather than expecting it to already be a list. This is a valid fix sinceSourceCode.requirementsisOptional[StrPipeVar](a single string path, not a list). No additional changes are needed beyond what's already in the repo.Related Issue
Fixes #5518
Changes Made
sagemaker-core/tests/unit/workflow/test_utilities.pyAI-Generated PR
This PR was automatically generated by the PySDK Issue Agent.
Merge Checklist
prefix: descriptionformat