feat(cli): add sync command#24
Open
natemoo-re wants to merge 5 commits intomainfrom
Open
Conversation
|
commit: |
natemoo-re
force-pushed
the
feat/sync-skills
branch
from
8ecf0e7 to
d9d3ad8
Compare
natemoo-re
force-pushed
the
feat/sync-skills
branch
from
d9d3ad8 to
47e2634
Compare
gameroman
reviewed
Apr 30, 2026
Comment on lines
+179
to
+199
| async function isSelf(root: URL): Promise<boolean> { | ||
| const pkgPath = new URL("package.json", root); | ||
| if (!(await exists(pkgPath))) return false; | ||
| const content = await readFile(pkgPath, "utf8"); | ||
| const pkg = JSON.parse(content) as { name?: string }; | ||
| return pkg.name === "@bomb.sh/tools"; | ||
| } | ||
|
|
||
| async function exists(url: URL): Promise<boolean> { | ||
| try { | ||
| await readdir(url); | ||
| return true; | ||
| } catch { | ||
| try { | ||
| await readFile(url); | ||
| return true; | ||
| } catch { | ||
| return false; | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This might cause a race condition and it feels inefficient, exists calls readdir and readFile, for then to do readFile again
Something like this is probably better
async function isSelf(root: URL): Promise<boolean> {
const content = await safeRead(new URL("package.json", root));
if (!content) return false;
const pkg = JSON.parse(content) as { name?: string };
return pkg.name === "@bomb.sh/tools";
}
async function read(url: URL): Promise<string | null> {
try {
return await readFile(url, "utf8");
} catch (err) {
if (err.code === "ENOENT") return null;
throw err;
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes @tanstack/intent, add explicit
bsh synccommand to copy package skills to user'sskills