Add missing stack map declaration for array.new_elem#12936
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Apr 2, 2026
Merged
Add missing stack map declaration for array.new_elem#12936fitzgen merged 1 commit intobytecodealliance:mainfrom
array.new_elem#12936fitzgen merged 1 commit intobytecodealliance:mainfrom
Conversation
github-actions
Bot
added
cranelift
`translate_array_new_elem` created a GC reference (array ref) via a libcall but did not call `builder.declare_value_needs_stack_map()` on the result. This meant the reference was not included in stack maps at subsequent safepoints, so if a GC occurred, the reference became stale (leading to use-after-free within the GC heap sandbox).
fitzgen
force-pushed
the
array-new-elem-missing-stack-map
branch
from
def2196 to
aaf4418
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
translate_array_new_elemcreated a GC reference (array ref) via a libcall butdid not call
builder.declare_value_needs_stack_map()on the result. This meantthe reference was not included in stack maps at subsequent safepoints, so if a
GC occurred, the reference became stale (leading to use-after-free within the GC
heap sandbox).
Depends on #12935