feat: add example Rock app#338
Open
Juozas-Petkelis wants to merge 9 commits into
Open
Conversation
Juozas-Petkelis
force-pushed
the
feat/rock-example
branch
from
85a2e8f to
3295c91
Compare
artus9033
reviewed
May 19, 2026
Comment on lines
+3
to
+14
| # Run Script Build Phase invoked by the "Brownfield Apple App" target after | ||
| # the standard "Embed Frameworks" phase. | ||
| # | ||
| # When the host RN project is RockApp, the dynamic BrownfieldLib.dylib | ||
| # produced by `rock package:ios` has @rpath load commands for | ||
| # React.framework and ReactNativeDependencies.framework. They must be | ||
| # embedded in the .app bundle or the app crashes on launch with | ||
| # "Library not loaded: @rpath/React.framework/React". | ||
| # | ||
| # `prepareXCFrameworks.js --appName RockApp` drops these xcframeworks into | ||
| # `package/`. For Vanilla / Expo flavors they are absent (React core is | ||
| # statically linked into BrownfieldLib), so this script is a no-op then. |
Collaborator
There was a problem hiding this comment.
This should already be happening
Collaborator
There was a problem hiding this comment.
We can remove - already addressed in merged #323
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a demo app & CLI support for Rock
This PR:
Creates new example app for Rock
yarn create rockin package RockAppBrownfield Apple App Rockfor iOS consumer appbrownfield-example-sharedpackage for RNApp and RockApp example appsWrapped container in a
ScrollViewto fix the native message list being cut offRefactored "Send message to Native" button to the
<Button />component to look and behave the same as other buttonsHome screen before and after
Adjust actions and CI to support Rock
embed-rock-runtime-frameworks.shand adjustprepareXCFrameworks.jsscripts for Rock. Rockbrownfield:package:iosemit different on-disk shape than Vanilla RN, there's no Brownie.xcframework or BrownfieldNavigation.xcframework. AddjustedprepareXCFrameworks.jsto change rock build output to the layout the AppleApp Xcode project expects.Test plan
iOS
yarnin the root of the repository to install all dependenciesapps/RockApp/iosrunpod installapps/RockApprunyarn brownfield:package:iosapps/AppleApprunyarn build:example:ios-consumer:rockBrownfield Apple App RockschemaAndroid
yarnin the root of the repository to install all dependenciesapps/RockApprunyarn brownfield:package:androidandyarn brownfield:publish:androidRock example App